[
https://issues.apache.org/jira/browse/ARTEMIS-3464?focusedWorklogId=648750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648750
]
ASF GitHub Bot logged work on ARTEMIS-3464:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 17:12
Start Date: 09/Sep/21 17:12
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3728:
URL: https://github.com/apache/activemq-artemis/pull/3728#discussion_r705540526
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPReplicaTest.java
##########
@@ -640,25 +640,32 @@ private void replicaTest(boolean largeMessage,
server_2.startBrokerConnection(brokerConnectionName);
}
+ snfreplica = server_2.locateQueue(replica.getMirrorSNF());
Review comment:
But not this test? Its populated 11 lines earlier, just before the
connection is stopped and started for "making sure we wouldn't duplicate the
mirror". I couple maybe see adding an assertion here that doing a new locate
returns the exact same queue object, i.e that the connection stop/start process
didnt disturb the queue, but I dont really see reason to just reset the
variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 648750)
Time Spent: 1h (was: 50m)
> Mirror could Miss Acks with Paging
> ----------------------------------
>
> Key: ARTEMIS-3464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3464
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.18.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The Mirror target could miss acks in some cases with Paging.
> We should add a scan for when the message couldn't be reached within depaged
> messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
