[
https://issues.apache.org/jira/browse/ARTEMIS-3464?focusedWorklogId=650050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650050
]
ASF GitHub Bot logged work on ARTEMIS-3464:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/21 14:32
Start Date: 13/Sep/21 14:32
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3737:
URL: https://github.com/apache/activemq-artemis/pull/3737#discussion_r707394150
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
##########
@@ -153,7 +157,7 @@ public void performScanAck() {
// we should only have a max of 2 scheduled tasks
// one that's might still be currently running, and another one lined up
// no need for more than that
- if (scheduledScanCount.incrementAndGet() < 2) {
+ if (scheduledScanCount.incrementAndGet() <= 2) {
Review comment:
Ah, I thought it was the IO threads calling it, I see now it is the
Queue thread. I do still think it makes sense for it to protect itself though
rather than rely on callers to though, certainly as it _appears_ to try to
currently but doesnt entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 650050)
Time Spent: 3h 50m (was: 3h 40m)
> Mirror could Miss Acks with Paging
> ----------------------------------
>
> Key: ARTEMIS-3464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3464
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.18.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> The Mirror target could miss acks in some cases with Paging.
> We should add a scan for when the message couldn't be reached within depaged
> messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
