[
https://issues.apache.org/jira/browse/ARTEMIS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414510#comment-17414510
]
ASF subversion and git services commented on ARTEMIS-3475:
----------------------------------------------------------
Commit 2481a784f3ba7648f4b4322335bd3d4061aa4b01 in activemq-artemis's branch
refs/heads/main from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=2481a78 ]
ARTEMIS-3475 avoiding possible recursion on toString and improving overal
PacketImpl toString
> Possible recursion on PacketImpl::toString
> ------------------------------------------
>
> Key: ARTEMIS-3475
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3475
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is a mix of a bug and a task...
> classes extending Packet on core client are using a method named
> getParentString() on the toString();
> The initial intent was to be simple and never to abuse inheritance on the
> getParentString();
> Recent iteration on the code added a few occasions with toString() calling
> getParentString() calling toString() what caused a recursive loop.
> I'm making this simpler. by introducing a getPacketString() on PacketImpl
> where every extension of PacketImpl to simply call super.getParentString();
> Even though it still possible for someone to call itself on
> getParentString(), at least it would be clearer and easier to catch on
> revisions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
