[
https://issues.apache.org/jira/browse/ARTEMIS-3163?focusedWorklogId=652222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652222
]
ASF GitHub Bot logged work on ARTEMIS-3163:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/21 09:27
Start Date: 17/Sep/21 09:27
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3479:
URL: https://github.com/apache/activemq-artemis/pull/3479#discussion_r710895000
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java
##########
@@ -61,6 +61,8 @@
public static final String USE_KQUEUE_PROP_NAME = "useKQueue";
+ public static final String USE_IOURING_PROP_NAME = "useIoUring";
Review comment:
Your recent comments Franz noted flagging everything with caution that
its experimental...this might be a simple spot to trivially bang the point home
to a user, making the option name reflect it...e.g "useIoUringExperimental"
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
##########
@@ -401,6 +406,21 @@ public ActiveMQThreadFactory run() {
acceptorType = KQUEUE_ACCEPTOR_TYPE;
logger.debug("Acceptor using native kqueue");
+ } else if (useIoUring && CheckDependencies.isIoUringAvailable()) {
Review comment:
You can probably add some metadata to artemis-server-osgi let it know
the io.netty.incubator.channel.uring package usages are optional.
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
##########
@@ -112,6 +113,7 @@
public static final String NIO_ACCEPTOR_TYPE = "NIO";
public static final String EPOLL_ACCEPTOR_TYPE = "EPOLL";
public static final String KQUEUE_ACCEPTOR_TYPE = "KQUEUE";
+ public static final String IOURING_ACCEPTOR_TYPE = "IO_URING";
Review comment:
Perhaps Franz wanted to avoid a ring of IOUs...but more probably its
just that io_uring actually has the underscore in its name whilst I dont think
the others do. Reasonable point about URL based config...though I thought it
was just a boolean there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 652222)
Time Spent: 4.5h (was: 4h 20m)
> Experimental support for Netty IO_URING incubator
> -------------------------------------------------
>
> Key: ARTEMIS-3163
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3163
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Attachments: flamegraphs.zip
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Netty provides incubator support (ie not for production use yet) for IO_URING
> (see https://github.com/netty/netty-incubator-transport-io_uring).
> It would be nice for Artemis to support it and allows devs/users to start
> playing with it.
> To enable this feature to work, users should manually compile
> https://github.com/netty/netty-incubator-transport-io_uring and place it on
> the lib folder of an artemis installation, as expected by an experimental
> feature ;)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
