[ 
https://issues.apache.org/jira/browse/AMQNET-735?focusedWorklogId=653827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653827
 ]

ASF GitHub Bot logged work on AMQNET-735:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/21 21:04
            Start Date: 21/Sep/21 21:04
    Worklog Time Spent: 10m 
      Work Description: Havret commented on a change in pull request #26:
URL: https://github.com/apache/activemq-nms-api/pull/26#discussion_r713412955



##########
File path: src/nms-api/IMessageConsumer.cs
##########
@@ -69,10 +75,15 @@ public interface IMessageConsumer : System.IDisposable
         IMessage ReceiveNoWait();
 
         /// <summary>
-        /// An asynchronous listener which can be used to consume messages 
asynchronously

Review comment:
       It's not the matter of callback or poll. It's just a matter or naming 
thing properly so other developers can understand what's going on here. 
   
   The difference between this two callbacks is as follows. The second allows 
the client to run asynchronous code inside, and the first doesn't. It can only 
run synchronous code. Documenting the first as asynchronous is a bit 
counterintuitive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 653827)
    Time Spent: 1h 40m  (was: 1.5h)

> Add option to consume messages asynchronously
> ---------------------------------------------
>
>                 Key: AMQNET-735
>                 URL: https://issues.apache.org/jira/browse/AMQNET-735
>             Project: ActiveMQ .Net
>          Issue Type: New Feature
>          Components: AMQP, NMS
>    Affects Versions: AMQP-2.0.0
>            Reporter: Krzysztof Porębski
>            Assignee: Krzysztof Porębski
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Add API allowing to consume messages asynchronously.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to