[ 
https://issues.apache.org/jira/browse/ARTEMIS-3494?focusedWorklogId=654591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654591
 ]

ASF GitHub Bot logged work on ARTEMIS-3494:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Sep/21 16:13
            Start Date: 23/Sep/21 16:13
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on pull request #3768:
URL: https://github.com/apache/activemq-artemis/pull/3768#issuecomment-925958580


   Seems unusual to explicitly render the static method unused in the Artemis 
codebase and then not modify it in some way (e.g deprecation, or removal). As 
is anyone could just choose to remove it as 'unused', though it sounds like you 
may have existing code that was relying on it. Its also now unused and untested 
for anyone else still relying on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 654591)
    Time Spent: 1h 10m  (was: 1h)

> ActiveMQClientProtocolManagerFactory shouldn't have a private constructor
> -------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3494
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3494
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.18.0
>            Reporter: Emmanuel Hugonnet
>            Priority: Major
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> ActiveMQClientProtocolManagerFactory has a private constructor which prevents 
> setting it with ActiveMQConnectionFactory.setProtocolManagerFactoryStr



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to