[
https://issues.apache.org/jira/browse/ARTEMIS-3496?focusedWorklogId=654942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654942
]
ASF GitHub Bot logged work on ARTEMIS-3496:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/21 12:28
Start Date: 24/Sep/21 12:28
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #3771:
URL: https://github.com/apache/activemq-artemis/pull/3771#issuecomment-926585839
it was set to 1 as in not meant to retry.. .a single connection...
its a bug... I meant for one connection only.
Replication and clustering should have the retries through the cluster
bridge and clustered connection. not through the serverLocator.
Is there a test that fails with this? run the whole test suite just in
case.. and if you can add a failing test it would be even greater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 654942)
Time Spent: 0.5h (was: 20m)
> Replica connection to its live should fail fast
> -----------------------------------------------
>
> Key: ARTEMIS-3496
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3496
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Both SharedNothingBackupActivation and ReplicationBackupActivation set
> session factory's cluster control reconnect attempts to 1, but the comment on
> the code for the former says:
> {code:java}
> //we should only try once, if its not there we should move on.
> {code}
> That doesn't look right, indeed, in case of failed cluster connection due to
> TTL, the additional attempt to reconnect slow down the whole failover process.
> As per the comment, to try connect just once, reconnect attempts should be
> set to 0.
> The weird thing is that the same session factory is created (along with the
> initial connection) with reconnectAttempts == 0 by
> ClusterController::connectToNodeInReplicatedCluster, before authorizing and
> starting the initial sync.
> Need an investigation to find out why it seems to be set to 1 from the
> original correct value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
