[
https://issues.apache.org/jira/browse/ARTEMIS-3502?focusedWorklogId=662410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-662410
]
ASF GitHub Bot logged work on ARTEMIS-3502:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/21 23:42
Start Date: 07/Oct/21 23:42
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3777:
URL: https://github.com/apache/activemq-artemis/pull/3777#discussion_r723982394
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java
##########
@@ -2006,8 +2006,8 @@ void slowConsumerDetected(String sessionID,
void incompatibleWithHAPolicyChosen(String parameter);
@LogMessage(level = Logger.Level.ERROR)
- @Message(id = 224065, value = "Failed to remove auto-created queue {0}",
format = Message.Format.MESSAGE_FORMAT)
- void errorRemovingAutoCreatedQueue(@Cause Exception e, SimpleString
bindingName);
+ @Message(id = 224065, value = "Failed to remove auto-created {1} {0}",
format = Message.Format.MESSAGE_FORMAT)
+ void errorRemovingAutoCreatedDestination(@Cause Exception e, SimpleString
bindingName, String destinationType);
Review comment:
I just noticed this is how you fixed the prior comment around it calling
_errorRemovingAutoCreatedQueue_ during _address_ cleanup. I wasn't expecting a
rename since there is already an 'errorRemovingAutoCreatedAddress' method here
(224070), the cleanup was just calling the wrong method.
Was the desire to keep using the same code? If so should the
seemingly-unused 224070 one be marked deprecated and direct people here now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 662410)
Time Spent: 5h 10m (was: 5h)
> Auto delete of a queue could lead to inconsistencies
> ----------------------------------------------------
>
> Key: ARTEMIS-3502
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3502
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Auto delete might happen after a disconnect of consumers.
> on a situation where the consumer was up to date the queue could be removed,
> leading to a few issues.
> we should improve how we handle with auto-delete and avoid these
> inconsistencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
