[ 
https://issues.apache.org/jira/browse/ARTEMIS-3523?focusedWorklogId=668056&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668056
 ]

ASF GitHub Bot logged work on ARTEMIS-3523:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/21 01:45
            Start Date: 21/Oct/21 01:45
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on a change in pull request 
#3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r733259828



##########
File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##########
@@ -574,6 +574,11 @@ public long purge() throws Exception {
       return totalMsgs;
    }
 
+   @Override
+   public void replay() throws Exception {

Review comment:
       I think you the signature should be the same one on ServerControl minus 
the address...
   
   other than that you're spot on on the change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 668056)
    Time Spent: 50m  (was: 40m)

> Expose replay through AddressControl
> ------------------------------------
>
>                 Key: ARTEMIS-3523
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3523
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Clebert Suconic
>            Priority: Major
>              Labels: easy
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently there is a method replay on ActiveMQServer with the following 
> signature:
> replay(address, .....)
> it should be a lot easier for our users to implement a method replay on the 
> ActiveMQServerControl
> such method should just call server.replay(this.address, .....)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to