[
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=670420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-670420
]
ASF GitHub Bot logged work on AMQ-7309:
---------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/21 23:53
Start Date: 26/Oct/21 23:53
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on a change in pull
request #682:
URL: https://github.com/apache/activemq/pull/682#discussion_r737004363
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
Review comment:
nit: indentation
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
+ public void setDeliveryDelay(long deliveryDelay) throws JMSException {
+ throw new UnsupportedOperationException("setDeliveryDelay() is not
supported");
+ }
+
+ /**
Review comment:
nit: indentation
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
Review comment:
nit: indentation
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
+ public void setDeliveryDelay(long deliveryDelay) throws JMSException {
+ throw new UnsupportedOperationException("setDeliveryDelay() is not
supported");
Review comment:
nit: indentation
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java
##########
@@ -285,8 +286,40 @@ public TopicConnection createTopicConnection() throws
JMSException {
public TopicConnection createTopicConnection(String userName, String
password) throws JMSException {
return createActiveMQConnection(userName, password);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
Review comment:
nit: indentation
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java
##########
@@ -285,8 +286,40 @@ public TopicConnection createTopicConnection() throws
JMSException {
public TopicConnection createTopicConnection(String userName, String
password) throws JMSException {
return createActiveMQConnection(userName, password);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
Review comment:
nit: indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 670420)
Time Spent: 12h (was: 11h 50m)
> Add JMS 2.0 support
> -------------------
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Broker, JMS client
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 12h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
