[
https://issues.apache.org/jira/browse/ARTEMIS-3541?focusedWorklogId=675393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675393
]
ASF GitHub Bot logged work on ARTEMIS-3541:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 00:47
Start Date: 04/Nov/21 00:47
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3835:
URL: https://github.com/apache/activemq-artemis/pull/3835#discussion_r742134408
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java
##########
@@ -1090,7 +1090,7 @@ void destroyQueue(@Parameter(name = "name", desc = "Name
of the queue to destroy
@Operation(desc = "Destroy a queue", impact = MBeanOperationInfo.ACTION)
void destroyQueue(@Parameter(name = "name", desc = "Name of the queue to
destroy") String name,
@Parameter(name = "removeConsumers", desc = "Remove
consumers of this queue") boolean removeConsumers,
- @Parameter(name = "forceAutoDeleteAddress", desc =
"Automatically delete the address if this was the last queue") boolean
autoDeleteAddress) throws Exception;
+ @Parameter(name = "instantAutoDeleteAddress", desc =
"Immediately delete the auto-created address if this was the last queue,
ignoring any settings from address-settings") boolean autoDeleteAddress) throws
Exception;
Review comment:
@gemmellr actually, I think I should remove the check on delay... if you
need a delay check, just do it through the reaper. When the instantForce is
called, it's actually meant to remove it right away and ignore any settings.
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ActiveMQServerControl.java
##########
@@ -1090,7 +1090,7 @@ void destroyQueue(@Parameter(name = "name", desc = "Name
of the queue to destroy
@Operation(desc = "Destroy a queue", impact = MBeanOperationInfo.ACTION)
void destroyQueue(@Parameter(name = "name", desc = "Name of the queue to
destroy") String name,
@Parameter(name = "removeConsumers", desc = "Remove
consumers of this queue") boolean removeConsumers,
- @Parameter(name = "forceAutoDeleteAddress", desc =
"Automatically delete the address if this was the last queue") boolean
autoDeleteAddress) throws Exception;
+ @Parameter(name = "instantAutoDeleteAddress", desc =
"Immediately delete the auto-created address if this was the last queue,
ignoring any settings from address-settings") boolean autoDeleteAddress) throws
Exception;
Review comment:
@gemmellr actually, I think I should remove the check on delay... if you
need a delay check, just do it through the reaper. When the instantForce is
called, it's actually meant to remove it right away and ignore any settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 675393)
Time Spent: 6h 10m (was: 6h)
> destroyQueue ignoring autoDeleteAddress flag
> --------------------------------------------
>
> Key: ARTEMIS-3541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3541
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
