[
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=675513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675513
]
ASF GitHub Bot logged work on AMQ-7309:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 00:57
Start Date: 04/Nov/21 00:57
Worklog Time Spent: 10m
Work Description: mattrpav commented on a change in pull request #682:
URL: https://github.com/apache/activemq/pull/682#discussion_r742267823
##########
File path:
activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/PooledConnection.java
##########
@@ -162,6 +162,44 @@ public TopicSession createTopicSession(boolean transacted,
int ackMode) throws J
return (TopicSession) createSession(transacted, ackMode);
}
+ /**
+ * Creates a <CODE>Session</CODE> object.
+ *
+ * @throws JMSException if the <CODE>Connection</CODE> object fails to
+ * create a session due to some internal error or lack of
+ * support for the specific transaction and acknowledgement
+ * mode.
+ * @since 2.0
+ */
+ @Override
+ public Session createSession() throws JMSException {
+ throw new UnsupportedOperationException("createSession() is
unsupported");
+ }
+
+ /**
+ * Creates a <CODE>Session</CODE> object.
+ *
+ * @param acknowledgeMode indicates whether the consumer or the client will
+ * acknowledge any messages it receives; ignored if the
+ * session is transacted. Legal values are
+ * <code>Session.AUTO_ACKNOWLEDGE</code>,
+ * <code>Session.CLIENT_ACKNOWLEDGE</code>, and
+ * <code>Session.DUPS_OK_ACKNOWLEDGE</code>.
+ * @return a newly created session
+ * @throws JMSException if the <CODE>Connection</CODE> object fails to
+ * create a session due to some internal error or lack of
+ * support for the specific transaction and acknowledgement
+ * mode.
+ * @see Session#AUTO_ACKNOWLEDGE
+ * @see Session#CLIENT_ACKNOWLEDGE
+ * @see Session#DUPS_OK_ACKNOWLEDGE
+ * @since 2.0
+ */
+ @Override
+ public Session createSession(int sessionMode) throws JMSException {
+ throw new UnsupportedOperationException("createSession(int sessionMode)
is unsupported");
Review comment:
Fixed
##########
File path:
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionFactory.java
##########
@@ -77,8 +78,40 @@ public Connection createConnection(String userName, String
password) throws JMSE
i.setPassword(password);
return createConnection(i);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password) {
+ throw new UnsupportedOperationException("createContext(userName,
password) is not supported");
+ }
/**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password, int
sessionMode) {
+ throw new UnsupportedOperationException("createContext(userName,
password, sessionMode) is not supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(int sessionMode) {
+ throw new UnsupportedOperationException("createContext(sessionMode) is
not supported");
+ }
Review comment:
Fixed
##########
File path:
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionFactory.java
##########
@@ -77,8 +78,40 @@ public Connection createConnection(String userName, String
password) throws JMSE
i.setPassword(password);
return createConnection(i);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password) {
+ throw new UnsupportedOperationException("createContext(userName,
password) is not supported");
+ }
/**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password, int
sessionMode) {
+ throw new UnsupportedOperationException("createContext(userName,
password, sessionMode) is not supported");
+ }
Review comment:
Fixed
##########
File path:
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionFactory.java
##########
@@ -77,8 +78,40 @@ public Connection createConnection(String userName, String
password) throws JMSE
i.setPassword(password);
return createConnection(i);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password) {
+ throw new UnsupportedOperationException("createContext(userName,
password) is not supported");
+ }
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -66,7 +91,7 @@ public void setDisableMessageID(boolean value) throws
JMSException {
this.disableMessageID = value;
}
- /**
+ /**
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
+ public void setDeliveryDelay(long deliveryDelay) throws JMSException {
+ throw new UnsupportedOperationException("setDeliveryDelay() is not
supported");
+ }
+
+ /**
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
+ public void setDeliveryDelay(long deliveryDelay) throws JMSException {
+ throw new UnsupportedOperationException("setDeliveryDelay() is not
supported");
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java
##########
@@ -285,8 +286,40 @@ public TopicConnection createTopicConnection() throws
JMSException {
public TopicConnection createTopicConnection(String userName, String
password) throws JMSException {
return createActiveMQConnection(userName, password);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java
##########
@@ -285,8 +286,40 @@ public TopicConnection createTopicConnection() throws
JMSException {
public TopicConnection createTopicConnection(String userName, String
password) throws JMSException {
return createActiveMQConnection(userName, password);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java
##########
@@ -307,6 +307,44 @@ public JMSConnectionStatsImpl getConnectionStats() {
/**
* Creates a <CODE>Session</CODE> object.
*
+ * @throws JMSException if the <CODE>Connection</CODE> object fails to
+ * create a session due to some internal error or lack of
+ * support for the specific transaction and acknowledgement
+ * mode.
+ * @since 2.0
+ */
+ @Override
Review comment:
fixed
##########
File path:
activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/PooledConnection.java
##########
@@ -162,6 +162,44 @@ public TopicSession createTopicSession(boolean transacted,
int ackMode) throws J
return (TopicSession) createSession(transacted, ackMode);
}
+ /**
+ * Creates a <CODE>Session</CODE> object.
+ *
+ * @throws JMSException if the <CODE>Connection</CODE> object fails to
+ * create a session due to some internal error or lack of
+ * support for the specific transaction and acknowledgement
+ * mode.
+ * @since 2.0
+ */
+ @Override
+ public Session createSession() throws JMSException {
+ throw new UnsupportedOperationException("createSession() is
unsupported");
+ }
+
+ /**
+ * Creates a <CODE>Session</CODE> object.
+ *
+ * @param acknowledgeMode indicates whether the consumer or the client will
+ * acknowledge any messages it receives; ignored if the
+ * session is transacted. Legal values are
+ * <code>Session.AUTO_ACKNOWLEDGE</code>,
+ * <code>Session.CLIENT_ACKNOWLEDGE</code>, and
+ * <code>Session.DUPS_OK_ACKNOWLEDGE</code>.
+ * @return a newly created session
+ * @throws JMSException if the <CODE>Connection</CODE> object fails to
+ * create a session due to some internal error or lack of
+ * support for the specific transaction and acknowledgement
+ * mode.
+ * @see Session#AUTO_ACKNOWLEDGE
+ * @see Session#CLIENT_ACKNOWLEDGE
+ * @see Session#DUPS_OK_ACKNOWLEDGE
+ * @since 2.0
+ */
+ @Override
+ public Session createSession(int sessionMode) throws JMSException {
+ throw new UnsupportedOperationException("createSession(int sessionMode)
is unsupported");
Review comment:
Fixed
##########
File path:
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionFactory.java
##########
@@ -77,8 +78,40 @@ public Connection createConnection(String userName, String
password) throws JMSE
i.setPassword(password);
return createConnection(i);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password) {
+ throw new UnsupportedOperationException("createContext(userName,
password) is not supported");
+ }
/**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password, int
sessionMode) {
+ throw new UnsupportedOperationException("createContext(userName,
password, sessionMode) is not supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(int sessionMode) {
+ throw new UnsupportedOperationException("createContext(sessionMode) is
not supported");
+ }
Review comment:
Fixed
##########
File path:
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionFactory.java
##########
@@ -77,8 +78,40 @@ public Connection createConnection(String userName, String
password) throws JMSE
i.setPassword(password);
return createConnection(i);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password) {
+ throw new UnsupportedOperationException("createContext(userName,
password) is not supported");
+ }
/**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password, int
sessionMode) {
+ throw new UnsupportedOperationException("createContext(userName,
password, sessionMode) is not supported");
+ }
Review comment:
Fixed
##########
File path:
activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionFactory.java
##########
@@ -77,8 +78,40 @@ public Connection createConnection(String userName, String
password) throws JMSE
i.setPassword(password);
return createConnection(i);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
+ }
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext(String userName, String password) {
+ throw new UnsupportedOperationException("createContext(userName,
password) is not supported");
+ }
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -66,7 +91,7 @@ public void setDisableMessageID(boolean value) throws
JMSException {
this.disableMessageID = value;
}
- /**
+ /**
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
+ public void setDeliveryDelay(long deliveryDelay) throws JMSException {
+ throw new UnsupportedOperationException("setDeliveryDelay() is not
supported");
+ }
+
+ /**
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQMessageProducerSupport.java
##########
@@ -42,6 +42,31 @@ public ActiveMQMessageProducerSupport(ActiveMQSession
session) {
disableMessageTimestamp =
session.connection.isDisableTimeStampsByDefault();
}
+ /**
+ * Gets the delivery delay associated with this
<CODE>MessageProducer</CODE>.
+ *
+ * @return this producer's <CODE>DeliveryDely/ <CODE>
+ * @throws JMSException if the JMS provider fails to close the producer
due to
+ * some internal error.
+ * @since 2.0
+ */
+ @Override
+ public void setDeliveryDelay(long deliveryDelay) throws JMSException {
+ throw new UnsupportedOperationException("setDeliveryDelay() is not
supported");
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java
##########
@@ -285,8 +286,40 @@ public TopicConnection createTopicConnection() throws
JMSException {
public TopicConnection createTopicConnection(String userName, String
password) throws JMSException {
return createActiveMQConnection(userName, password);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
+ public JMSContext createContext() {
+ throw new UnsupportedOperationException("createContext() is not
supported");
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnectionFactory.java
##########
@@ -285,8 +286,40 @@ public TopicConnection createTopicConnection() throws
JMSException {
public TopicConnection createTopicConnection(String userName, String
password) throws JMSException {
return createActiveMQConnection(userName, password);
}
+
+ /**
+ * @return Returns the JMSContext.
+ */
+ @Override
Review comment:
Fixed
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConnection.java
##########
@@ -307,6 +307,44 @@ public JMSConnectionStatsImpl getConnectionStats() {
/**
* Creates a <CODE>Session</CODE> object.
*
+ * @throws JMSException if the <CODE>Connection</CODE> object fails to
+ * create a session due to some internal error or lack of
+ * support for the specific transaction and acknowledgement
+ * mode.
+ * @since 2.0
+ */
+ @Override
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 675513)
Time Spent: 13h 50m (was: 13h 40m)
> Add JMS 2.0 support
> -------------------
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
> Issue Type: New Feature
> Components: Broker, JMS client
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
