[
https://issues.apache.org/jira/browse/ARTEMIS-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erwin Dondorp updated ARTEMIS-3568:
-----------------------------------
Description:
The "Send message" screen has room for a few (sometimes minor) improvements.
I've bundled them in one PR.
* (fix) fixed delete-header-item on page send-message-to-queue due to broken js
code behind the delete-button (caught by viewing the diff between
addressSendMessage.js and sendMessage.js);
* (fix) fixed format-message on page send-message-to-queue due to broken js
code behind the format-button (this initially led me to believe that the button
would apply syntax-color only, until I saw the intended behaviour on page
send-message-to-address).
all of the below change apply to both send-message-to-queue and
send-message-to-address pages;
* (smallfix) fixed small spelling error in a help-text where "in" was spelled
as "ion";
* (smallfix) fixed small spelling error in a help-text where "it's" was spelled
as "its";
* (cosmetic) the dropdown-box for the format selection has been shrunk and the
button placed on the same line;
* (cosmetic) renamed button from "Send message" to "Send Message", just because
the "Add Header" button on the same page also uses capitals.
I read that "CodeEditor" also supported YAML and TOML. But when I tried it out,
the syntax colours only worked for YAML and the reformatting did not word for
any of these two. so that part was dropped before it was even committed.
!screenshot-3.png!
was:
The "Send message" screen has room for a few (sometimes minor) improvements.
I've bundled them in one PR.
* (cosmetic) the dropdown-box for the format selection has been shrunk and the
button placed on the same line;
* (improvement) the format "YAML" was added to the dropdown-box (as supported
by CodeMirror), the format "TOML" was added to the dropdown-box (as supported
by CodeMirror), no other formats offered by CodeMirror are relevant as they do
not represent data-types but programming-languages;
* (smallfix) fixed small spelling error in a help-text where "in" was spelled
as "ion";
* (smallfix) fixed small spelling error in a help-text where "it's" was spelled
as "its";
* (smallfix) renamed button from "Send message" to "Send Message", just because
the "Add Header" button on the same page also uses capitals;
* all of the above changed for both send-message-to-queue and
send-message-to-address pages;
* (fix) fixed delete-header-item on page send-message-to-queue due to broken js
code behind the delete-button (caught by viewing the diff between
addressSendMessage.js and sendMessage.js);
* (fix) fixed format-message on page send-message-to-queue due to broken js
code behind the format-button (this initially led me to believe that the button
would apply syntax-color only, until I saw the intended behaviour on page
send-message-to-address).
TODO: TOML does not work yet. actual PR will follow as soon as that detail is
fixed...
!screenshot-3.png!
> general improvement on the "Send message" screen
> ------------------------------------------------
>
> Key: ARTEMIS-3568
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3568
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: 2.19.0
> Reporter: Erwin Dondorp
> Priority: Trivial
> Attachments: screenshot-3.png
>
>
> The "Send message" screen has room for a few (sometimes minor) improvements.
> I've bundled them in one PR.
> * (fix) fixed delete-header-item on page send-message-to-queue due to broken
> js code behind the delete-button (caught by viewing the diff between
> addressSendMessage.js and sendMessage.js);
> * (fix) fixed format-message on page send-message-to-queue due to broken js
> code behind the format-button (this initially led me to believe that the
> button would apply syntax-color only, until I saw the intended behaviour on
> page send-message-to-address).
> all of the below change apply to both send-message-to-queue and
> send-message-to-address pages;
> * (smallfix) fixed small spelling error in a help-text where "in" was spelled
> as "ion";
> * (smallfix) fixed small spelling error in a help-text where "it's" was
> spelled as "its";
> * (cosmetic) the dropdown-box for the format selection has been shrunk and
> the button placed on the same line;
> * (cosmetic) renamed button from "Send message" to "Send Message", just
> because the "Add Header" button on the same page also uses capitals.
> I read that "CodeEditor" also supported YAML and TOML. But when I tried it
> out, the syntax colours only worked for YAML and the reformatting did not
> word for any of these two. so that part was dropped before it was even
> committed.
> !screenshot-3.png!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
