[
https://issues.apache.org/jira/browse/ARTEMIS-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erwin Dondorp updated ARTEMIS-3568:
-----------------------------------
Description:
The "Send message" screen has room for a few (sometimes minor) improvements.
I've bundled them in one PR.
* (fix) fixed delete-header-item on page send-message-to-queue due to broken js
code behind the delete-button (caught by viewing the diff between
addressSendMessage.js and sendMessage.js);
* (fix) fixed format-message on page send-message-to-queue due to broken js
code behind the format-button (this initially led me to believe that the button
would apply syntax-color only, until I saw the intended behaviour on page
send-message-to-address).
all of the below change apply to both send-message-to-queue and
send-message-to-address pages:
* (smallfix) fixed small spelling error in a help-text where "in" was spelled
as "ion";
* (smallfix) fixed small spelling error in a help-text where "it's" was spelled
as "its";
* (cosmetic) the dropdown-box for the format selection has been shrunk and the
button placed on the same line;
* (cosmetic) renamed button from "Send message" to "Send Message", just because
the "Add Header" button on the same page also uses capitals.
I read that "CodeEditor" also supported YAML and TOML. But when I tried it out,
the syntax colours only worked for YAML and the reformatting did not work for
any of these two. so that part was dropped before it was even committed.
note: internally there are 2 "Send message" screens. one to send a message to
an address, the other one to send a message to a queue. these screen look very
similar and have the same title and button name. the 2 screens can be only be
distinguished visually by looking at the help text from the (?) button just
after the page title. of course the one page is used when an address is
selected in the tree; the other when a queue is selected in the tree.
!screenshot-3.png!
was:
The "Send message" screen has room for a few (sometimes minor) improvements.
I've bundled them in one PR.
* (fix) fixed delete-header-item on page send-message-to-queue due to broken js
code behind the delete-button (caught by viewing the diff between
addressSendMessage.js and sendMessage.js);
* (fix) fixed format-message on page send-message-to-queue due to broken js
code behind the format-button (this initially led me to believe that the button
would apply syntax-color only, until I saw the intended behaviour on page
send-message-to-address).
all of the below change apply to both send-message-to-queue and
send-message-to-address pages:
* (smallfix) fixed small spelling error in a help-text where "in" was spelled
as "ion";
* (smallfix) fixed small spelling error in a help-text where "it's" was spelled
as "its";
* (cosmetic) the dropdown-box for the format selection has been shrunk and the
button placed on the same line;
* (cosmetic) renamed button from "Send message" to "Send Message", just because
the "Add Header" button on the same page also uses capitals.
I read that "CodeEditor" also supported YAML and TOML. But when I tried it out,
the syntax colours only worked for YAML and the reformatting did not word for
any of these two. so that part was dropped before it was even committed.
note: internally there are 2 "Send message" screens. one to send a message to
an address, the other one to send a message to a queue. these screen look very
similar and have the same title and button name. the 2 screens can be only be
distinguished visually by looking at the help text from the (?) button just
after the page title. of course the one page is used when an address is
selected in the tree; the other when a queue is selected in the tree.
!screenshot-3.png!
> fixes/improvements on the "Send message" screens
> ------------------------------------------------
>
> Key: ARTEMIS-3568
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3568
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Web Console
> Affects Versions: 2.19.0
> Reporter: Erwin Dondorp
> Priority: Minor
> Attachments: screenshot-3.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The "Send message" screen has room for a few (sometimes minor) improvements.
> I've bundled them in one PR.
> * (fix) fixed delete-header-item on page send-message-to-queue due to broken
> js code behind the delete-button (caught by viewing the diff between
> addressSendMessage.js and sendMessage.js);
> * (fix) fixed format-message on page send-message-to-queue due to broken js
> code behind the format-button (this initially led me to believe that the
> button would apply syntax-color only, until I saw the intended behaviour on
> page send-message-to-address).
> all of the below change apply to both send-message-to-queue and
> send-message-to-address pages:
> * (smallfix) fixed small spelling error in a help-text where "in" was spelled
> as "ion";
> * (smallfix) fixed small spelling error in a help-text where "it's" was
> spelled as "its";
> * (cosmetic) the dropdown-box for the format selection has been shrunk and
> the button placed on the same line;
> * (cosmetic) renamed button from "Send message" to "Send Message", just
> because the "Add Header" button on the same page also uses capitals.
> I read that "CodeEditor" also supported YAML and TOML. But when I tried it
> out, the syntax colours only worked for YAML and the reformatting did not
> work for any of these two. so that part was dropped before it was even
> committed.
> note: internally there are 2 "Send message" screens. one to send a message to
> an address, the other one to send a message to a queue. these screen look
> very similar and have the same title and button name. the 2 screens can be
> only be distinguished visually by looking at the help text from the (?)
> button just after the page title. of course the one page is used when an
> address is selected in the tree; the other when a queue is selected in the
> tree.
> !screenshot-3.png!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
