[ 
https://issues.apache.org/jira/browse/ARTEMIS-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443692#comment-17443692
 ] 

Ha Anh Vu commented on ARTEMIS-3173:
------------------------------------

{quote}

note: at 
[https://github.com/apache/activemq-artemis/blob/main/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java#L1582]
 - the iterator begins at 0 and all messages are ignored till we get to the 
start.

What I am thinking is provide an iterator that begins at start, such that line 
that gets the iterator looks something like: 
{code:java}
try (LinkedListIterator<MessageReference> iterator = 
queue.browserIterator(start)){code}
{quote}

[~gtully] yeah I saw that after rereading the code. That's why I deleted that 
comment.

 

Please reply to this comment:

{quote}

[~gtully] So basically on the highest level we need a new method like 
QueueControlImpl.browseFromStartOfPage(int page, int pageSize, String filter), 
right?

 
{quote}A little test that does the browse page view on messages that are paged 
would be a good start point to be able to compare the responsiveness of getting 
the 100th page when we start at 0 or 100*pageSize.
{quote}
You mean comparing starting at 0 and 99*pageSize?

{quote}

> Queue control browse message in paged mode should not start from the 
> beginning each time
> ----------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-3173
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3173
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: JMX
>    Affects Versions: 2.17.0
>            Reporter: Gary Tully
>            Priority: Minor
>
> The implementation of the paged browser creates a browser iterator and 
> searches from the start for each page contents. It wold be better if it was 
> possible to jump right in. Especially when messages are not in memory, ie: 
> address limit has caused paging.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to