[
https://issues.apache.org/jira/browse/ARTEMIS-3604?focusedWorklogId=693684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-693684
]
ASF GitHub Bot logged work on ARTEMIS-3604:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/21 02:41
Start Date: 10/Dec/21 02:41
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3876:
URL: https://github.com/apache/activemq-artemis/pull/3876#discussion_r766300277
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
##########
@@ -285,21 +333,41 @@ public void bufferReceived(Object connectionID,
ActiveMQBuffer buffer) {
traceBufferReceived(connectionID, command);
}
- final Actor<Command> localVisibleActor = openWireActor;
- if (localVisibleActor != null) {
- openWireActor.act(command);
- } else {
- act(command);
- }
+ runOnActor(command);
} catch (Exception e) {
ActiveMQServerLogger.LOGGER.debug(e);
sendException(e);
}
}
+ public void restoreAutoRead() {
+ if (!autoRead) {
+ autoRead = true;
+ openWireActor.act(flushWrite);
+ }
+ }
+
+ public void disableAutoRead() {
+ autoRead = false;
+ getTransportConnection().setAutoRead(false);
+ }
+
+ protected void actualEnableAutoReadAndTtl() {
+ getTransportConnection().setAutoRead(autoRead);
Review comment:
@gtully when blocked, autoRead will be false.
We are still calling the flush o this case though..
we will need the paging to send an event to set this call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 693684)
Remaining Estimate: 0h
Time Spent: 10m
> Async sends could overflow server with messages in openwire
> -----------------------------------------------------------
>
> Key: ARTEMIS-3604
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3604
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
