[
https://issues.apache.org/jira/browse/ARTEMIS-3627?focusedWorklogId=705133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-705133
]
ASF GitHub Bot logged work on ARTEMIS-3627:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/22 17:56
Start Date: 07/Jan/22 17:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3904:
URL: https://github.com/apache/activemq-artemis/pull/3904#discussion_r780431661
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
##########
@@ -429,8 +444,28 @@ public String getSystemPropertyPrefix() {
return systemPropertyPrefix;
}
+ public String getBrokerPropertiesSystemPropertyName() {
+ return brokerPropertiesSystemPropertyName;
+ }
+
+ public void setBrokerPropertiesSystemPropertyName(String
brokerPropertiesSystemPropertyName) {
+ this.brokerPropertiesSystemPropertyName =
brokerPropertiesSystemPropertyName;
+ }
+
@Override
- public Configuration parseSystemProperties() throws Exception {
+ public Configuration parseProperties() throws Exception {
+ final String propertiesConfigFileName =
System.getProperty(getBrokerPropertiesSystemPropertyName());
Review comment:
I think we should pass this through the CLI instead.
We could parse a default broker.properties on the instance/etc folder, and
the users would be able to pass another file with a ./artemis run --properties
<file>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 705133)
Time Spent: 20m (was: 10m)
> Allow properties to configure 'new' broker attributes and load from a file
> --------------------------------------------------------------------------
>
> Key: ARTEMIS-3627
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3627
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.20.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Following up on ARTEMIS-851, where simple set attributes can be overridden
> via system properties. This enhancement will allow properties to be loaded
> from broker.properties and allow additions to lists and maps.
> The additions to the collections require some naming convention. Many of the
> elements already support a name attribute and this can be used to locate and
> or create new entries.
> The idea is that a plain broker can be augmented with the presence of a
> properties file to add a new acceptor called "tcp" using properties of the
> form:
> acceptorConfigurations.tcp.params.HOST=localhost
> acceptorConfigurations.tcp.params.PORT=61616
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
