[
https://issues.apache.org/jira/browse/ARTEMIS-3616?focusedWorklogId=706922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706922
]
ASF GitHub Bot logged work on ARTEMIS-3616:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 15:06
Start Date: 11/Jan/22 15:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3887:
URL: https://github.com/apache/activemq-artemis/pull/3887#discussion_r782236488
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnector.java
##########
@@ -526,6 +526,14 @@ public synchronized void start() {
channelClazz = KQueueSocketChannel.class;
logger.debug("Connector " + this + " using native kqueue");
} else {
+ if (useEpoll) {
+ ActiveMQClientLogger.LOGGER.nettyEpollNotAvailable(this);
+ }
+
+ if (useKQueue) {
+ ActiveMQClientLogger.LOGGER.nettyKQueueNotAvailable(this);
+ }
+
Review comment:
Even with the environment asserted, there are cases in actual use that
its not going to be available by expectation and so such a log is going to be
wrong/misleading. I would simply log what is actually in use (which is already
done, at debug), not try and special case warnings. Simpler, and never wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 706922)
Time Spent: 1h 20m (was: 1h 10m)
> Netty epoll is not available
> ----------------------------
>
> Key: ARTEMIS-3616
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3616
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.20.0
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Netty epoll is not available because of ClassNotFoundException for
> io.netty.channel.unix.Errors$NativeIoException.
> To work around this issue you can copy
> https://repo1.maven.org/maven2/io/netty/netty-transport-native-unix-common/4.1.72.Final/netty-transport-native-unix-common-4.1.72.Final.jar
> into ARTEMIS/lib folder.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
