[
https://issues.apache.org/jira/browse/ARTEMIS-3649?focusedWorklogId=711239&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711239
]
ASF GitHub Bot logged work on ARTEMIS-3649:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/22 10:10
Start Date: 19/Jan/22 10:10
Worklog Time Spent: 10m
Work Description: gtully commented on a change in pull request #3918:
URL: https://github.com/apache/activemq-artemis/pull/3918#discussion_r787577622
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
##########
@@ -232,11 +232,24 @@ public ConsumerId getId() {
return info.getConsumerId();
}
- public void acquireCredit(int n) {
+ public void acquireCredit(int n, boolean delivered) {
if (messagePullHandler.get() != null) {
//don't acquire any credits when the pull handler controls it!!
return;
}
+
+ if (delivered) {
+ deliveredAcksCreditExtension += n;
+ } else if (deliveredAcksCreditExtension > 0) {
Review comment:
that is better, now the normal deliveredAcksCreditExtension == 0 branch
is clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 711239)
Remaining Estimate: 0h
Time Spent: 10m
> OpenWire consumers with zero prefetch get stuck
> -----------------------------------------------
>
> Key: ARTEMIS-3649
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3649
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Execute org.apache.activemq.ZeroPrefetchConsumerTest to reproduce the issue.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
