[
https://issues.apache.org/jira/browse/ARTEMIS-3573?focusedWorklogId=711420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711420
]
ASF GitHub Bot logged work on ARTEMIS-3573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/22 14:43
Start Date: 19/Jan/22 14:43
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r787801385
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/LazyHashProcessor.java
##########
@@ -0,0 +1,63 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.utils;
+
+public abstract class LazyHashProcessor implements HashProcessor {
+ private volatile HashProcessor hashProcessor;
+ private volatile RuntimeException supplierException;
+
+ public HashProcessor getHashProcessor() {
+ if (supplierException != null) {
+ throw supplierException;
+ }
+
+ if (hashProcessor == null) {
+ synchronized (this) {
+ if (supplierException != null) {
+ throw supplierException;
+ }
+
+ if (hashProcessor == null) {
+ try {
+ hashProcessor = createHashProcessor();
+ } catch (RuntimeException e) {
+ supplierException = e;
+ throw supplierException;
+ } catch (Exception e) {
+ supplierException = new RuntimeException(e);
+ throw supplierException;
+ }
+ }
+ }
+ }
+
+ return hashProcessor;
+ }
Review comment:
```suggestion
public abstract class LazyHashProcessor implements HashProcessor {
private volatile HashProcessor hashProcessor;
private RuntimeException supplierException;
public HashProcessor getHashProcessor() {
HashProcessor hp = hashProcessor;
if (hp == null) {
synchronized (this) {
if (supplierException != null) {
throw supplierException;
}
hp = hashProcessor;
if (hp == null) {
try {
hashProcessor = hp = createHashProcessor();
} catch (RuntimeException e) {
supplierException = e;
throw supplierException;
} catch (Exception e) {
supplierException = new RuntimeException(e);
throw supplierException;
}
}
}
}
return hp;
}
```
I think the initial if (supplierException != null) bit can just be removed,
and that field doesnt then need to be volatile as its then only used under
synchronization. The exception will only be non-null if hashProcessor is still
null, and whole the idea is to typically not expect it to be null, so it seems
unnecessary to pre-check the exception every time through. It can just rely on
the check at the start of the synchronized block.
I think it should also use the local variable to copy hashProcessor to as
typically expected in these cases.
Something like the suggestion (didnt check it compiles).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 711420)
Time Spent: 5h (was: 4h 50m)
> Support PropertiesLoginModule custom password codecs
> ----------------------------------------------------
>
> Key: ARTEMIS-3573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3573
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> The `PropertiesLoginModule` login module supports only the
> `DefaultSensitiveStringCodec` codec to verify the user passwords.
> Add a property to set a custom password codec, i.e.
> org.apache.activemq.jaas.properties.password.codec="org.apache.activemq.artemis.tests.integration.security.MD5SensitiveDataCodec"
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
