[
https://issues.apache.org/jira/browse/ARTEMIS-3653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erwin Dondorp updated ARTEMIS-3653:
-----------------------------------
Attachment: screenshot-1.png
> BrokerDiagram improvements, a.o. highlight the (real) current broker
> --------------------------------------------------------------------
>
> Key: ARTEMIS-3653
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3653
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: 2.20.0
> Reporter: Erwin Dondorp
> Priority: Minor
> Attachments: screenshot-1.png
>
>
> When viewing the broker diagram with up to one or two master nodes (and
> optionally a slave node for each) then it is unclear which node is the
> current node.
> When there are 3 or more master nodes, the connections between the nodes
> provide a clue (as the one with multiple connections is from the current
> pair). but still it is unclear whether the masternode or the slavenode of the
> current pair is the current node.
> The code shows that an attempt was made to highlight the current node.
> actually always the master node from the current pair is highlighted. since
> the styling is the same, that is not noticeable.
> The (upcoming) PR for this change will introduce proper highlighting of the
> current node. Simultaneously, the previous implementation is fixed where
> needed.
> Details:
> * remove comments about icons used for address/queue nodes as does not select
> an icon (I guess it might have done so in the past)
> * do not show ":61616" in the broker name, as that is the default
> * do not show quotes around addresses and queues
> *
> * The node-type "ThisBroker" is split into "ThisMasterBroker" and
> "ThisSlaveBroker"
> * "ThisMasterBroker" has the same style as "MasterBroker", but just with a
> black border
> * "ThisSlaveBroker" has the same style as "SlaveBroker", but just with a
> black border
> * use the same styling details for each node type
> *
> * determine whether the broker itself is master or slave. this is important
> to determine when to show the details. currently the details are shown when
> the master broker of the current pair is selected. with the new information
> the details can be selected for the correct broker icon.
> * apply the "new" styles to the current broker
> * when the current broker cannot be found in the topology, use the current
> broker-name instead of the text "broker". the brokers that are found in the
> topology are labelled with their hostname, so it is slightly different. the
> hostname does not seem to be available in the information that is retrieved
> for this diagram. It's too much work to get the actual hostname.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
