[
https://issues.apache.org/jira/browse/ARTEMIS-3627?focusedWorklogId=713776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713776
]
ASF GitHub Bot logged work on ARTEMIS-3627:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/22 14:06
Start Date: 24/Jan/22 14:06
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3924:
URL: https://github.com/apache/activemq-artemis/pull/3924#discussion_r790774612
##########
File path: tests/integration-tests/src/test/resources/broker.properties
##########
@@ -15,4 +15,6 @@
# limitations under the License.
#
-name=ConfiguredViaProperties
\ No newline at end of file
+# use a very innocuous bit of config b/c it will be picked up by all embedded
servers in the integration tests
Review comment:
The original change makes it look like the run command knows about it
and checksthe default name, passing it on if it exists. The broker having and
loading a file for _all_ the tests, that it is _not_ loading by default
typically (as it doesnt exist) for normal users, means it isnt the normal path
to me. It means the tests dont take the normal path (entirely reasonable when
actually testing that...questionable when not doing so).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 713776)
Time Spent: 3h 20m (was: 3h 10m)
> Allow properties to configure 'new' broker attributes and load from a file
> --------------------------------------------------------------------------
>
> Key: ARTEMIS-3627
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3627
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.20.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Following up on ARTEMIS-851, where simple set attributes can be overridden
> via system properties. This enhancement will allow properties to be loaded
> from broker.properties and allow additions to lists and maps.
> The additions to the collections require some naming convention. Many of the
> elements already support a name attribute and this can be used to locate and
> or create new entries.
> The idea is that a plain broker can be augmented with the presence of a
> properties file to add a new acceptor called "tcp" using properties of the
> form:
> acceptorConfigurations.tcp.params.host=localhost
> acceptorConfigurations.tcp.params.port=61616
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
