[
https://issues.apache.org/jira/browse/AMQ-8322?focusedWorklogId=715331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715331
]
ASF GitHub Bot logged work on AMQ-8322:
---------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/22 21:55
Start Date: 25/Jan/22 21:55
Worklog Time Spent: 10m
Work Description: mattrpav commented on a change in pull request #729:
URL: https://github.com/apache/activemq/pull/729#discussion_r792152293
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConsumer.java
##########
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq;
+
+import javax.jms.JMSConsumer;
+import javax.jms.JMSException;
+import javax.jms.JMSRuntimeException;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageListener;
+
+import org.apache.activemq.util.JMSExceptionSupport;
+
+public class ActiveMQConsumer implements JMSConsumer {
+
+ private final ActiveMQContext activemqContext;
+ private final MessageConsumer activemqMessageConsumer;
+
+ ActiveMQConsumer(ActiveMQContext activemqContext, MessageConsumer
activemqMessageConsumer) {
+ this.activemqContext = activemqContext;
+ this.activemqMessageConsumer = activemqMessageConsumer;
+ }
+
+ @Override
+ public String getMessageSelector() {
+ throw new UnsupportedOperationException("getMessageSelector() is not
supported");
+ }
+
+ @Override
+ public MessageListener getMessageListener() throws JMSRuntimeException {
+ throw new UnsupportedOperationException("getMessageListener() is not
supported");
Review comment:
This will be supported in a follow-on PR aligned with the approach to
implement and add tests in phases
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConsumer.java
##########
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq;
+
+import javax.jms.JMSConsumer;
+import javax.jms.JMSException;
+import javax.jms.JMSRuntimeException;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageListener;
+
+import org.apache.activemq.util.JMSExceptionSupport;
+
+public class ActiveMQConsumer implements JMSConsumer {
+
+ private final ActiveMQContext activemqContext;
+ private final MessageConsumer activemqMessageConsumer;
+
+ ActiveMQConsumer(ActiveMQContext activemqContext, MessageConsumer
activemqMessageConsumer) {
+ this.activemqContext = activemqContext;
+ this.activemqMessageConsumer = activemqMessageConsumer;
+ }
+
+ @Override
+ public String getMessageSelector() {
+ throw new UnsupportedOperationException("getMessageSelector() is not
supported");
+ }
+
+ @Override
+ public MessageListener getMessageListener() throws JMSRuntimeException {
+ throw new UnsupportedOperationException("getMessageListener() is not
supported");
+ }
+
+ @Override
+ public void setMessageListener(MessageListener listener) throws
JMSRuntimeException {
+ throw new
UnsupportedOperationException("setMessageListener(MessageListener) is not
supported");
Review comment:
This will be supported in a follow-on PR aligned with the approach to
implement and add tests in phases
##########
File path:
activemq-client/src/main/java/org/apache/activemq/ActiveMQConsumer.java
##########
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq;
+
+import javax.jms.JMSConsumer;
+import javax.jms.JMSException;
+import javax.jms.JMSRuntimeException;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageListener;
+
+import org.apache.activemq.util.JMSExceptionSupport;
+
+public class ActiveMQConsumer implements JMSConsumer {
+
+ private final ActiveMQContext activemqContext;
+ private final MessageConsumer activemqMessageConsumer;
+
+ ActiveMQConsumer(ActiveMQContext activemqContext, MessageConsumer
activemqMessageConsumer) {
+ this.activemqContext = activemqContext;
+ this.activemqMessageConsumer = activemqMessageConsumer;
+ }
+
+ @Override
+ public String getMessageSelector() {
Review comment:
This will be supported in a follow-on PR aligned with the approach to
implement and add tests in phases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 715331)
Time Spent: 50m (was: 40m)
> Implement JMS 2.0 Connection createContext methods
> --------------------------------------------------
>
> Key: AMQ-8322
> URL: https://issues.apache.org/jira/browse/AMQ-8322
> Project: ActiveMQ
> Issue Type: Sub-task
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add support for JMSContext, JMSProducer and JMSConsumer for working with
> queues
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
