[ 
https://issues.apache.org/jira/browse/ARTEMIS-3638?focusedWorklogId=716461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716461
 ]

ASF GitHub Bot logged work on ARTEMIS-3638:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jan/22 14:44
            Start Date: 27/Jan/22 14:44
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #3907:
URL: 
https://github.com/apache/activemq-artemis/pull/3907#issuecomment-1023283334


   The only thing I don't like on this PR is the "leakage" of 
getMqttSessionScanInterval on ConfigurationImpl.
   
   I would prefer it being a bean util property on the MQTT Protocol Manager. 
Make the scanInterval as part of the default configuration so it's easier for 
users to see it in there.
   
   
   Do you really need it on the Configurationimpl / Configuration or would you 
be able to make it part of MQTTProtocolManager and a beanutil property?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 716461)
    Time Spent: 1h 40m  (was: 1.5h)

> Support MQTT 5
> --------------
>
>                 Key: ARTEMIS-3638
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3638
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to