[ 
https://issues.apache.org/jira/browse/ARTEMIS-3660?focusedWorklogId=720790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720790
 ]

ASF GitHub Bot logged work on ARTEMIS-3660:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Feb/22 10:16
            Start Date: 04/Feb/22 10:16
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on pull request #3932:
URL: 
https://github.com/apache/activemq-artemis/pull/3932#issuecomment-1029833485


   @gtully I agree with you: `target` in the configuration is a little 
confusing. What about `ConnectionKey` to replace `TargetKey`and 
`ConnectionHandler` to replace `BrokerBalancer`. So acceptor can define the 
connectionHandler that will handles the connections and the ConnectionHandler 
can define the key of the connection to apply its filters/polices.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 720790)
    Time Spent: 0.5h  (was: 20m)

> broker balancer - tidy up configuration naming
> ----------------------------------------------
>
>                 Key: ARTEMIS-3660
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3660
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: balancer
>    Affects Versions: 2.20.0
>            Reporter: Gary Tully
>            Priority: Major
>             Fix For: 2.21.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> the use of target in the configuration is a little confusing and extra 
> verbose...
> in place of target-key I propose key-type
> in place of target-key-filter I propose key-filter
>  
> While released, this feature is not yet used in the wild. I think we can just 
> fix this without regard to deprecation at this point.
>  
> It has been flagged as experimental in the doc[1]:
> h3. This feature is still *EXPERIMENTAL* and not meant to be run in 
> production yet. Furthermore, its configuration can change until declared as 
> {*}officially stable{*}.
>  
> [1] 
> https://activemq.apache.org/components/artemis/documentation/latest/broker-balancers.html
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to