[
https://issues.apache.org/jira/browse/AMQ-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487183#comment-17487183
]
Christopher L. Shannon edited comment on AMQ-8412 at 2/4/22, 5:00 PM:
----------------------------------------------------------------------
This issue seems to cause a regression and I think needs to be backed out. The
problem is this completely changes existing client behavior which should close
the connection on max message failure. Now the connection will stay open.
Generally speaking making changes like this without preserving backwards
compatibility is a no go.
It breaks my test case from https://issues.apache.org/jira/browse/AMQ-8183
Was that test disabled in Jenkins? I would have expected the automated tests to
catch it if not.
Also, there are no tests here which is another big problem as mentioned already.
was (Author: christopher.l.shannon):
This issue seems to cause a regression and I think needs to be backed out. The
problem is this completely changes existing client behavior which should close
the connection on max message failure. Now the connection will stay open.
Generally speaking making changes like this without preserving backwards
compatibility is a no go.
It breaks my test case from https://issues.apache.org/jira/browse/AMQ-8183
Was that test disabled in Jenkins? I would have expected the automated tests to
catch it if not.
Also, there are no tests here which is another big problem as mentioned already.
> Return a well-formed response to clients when max message size is sent
> ----------------------------------------------------------------------
>
> Key: AMQ-8412
> URL: https://issues.apache.org/jira/browse/AMQ-8412
> Project: ActiveMQ
> Issue Type: New Feature
> Components: JMS client
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0, 5.16.4
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, clients get an inconclusive exception when a message that is too
> large is sent. We should send a well-formed message, and then close.
> Options:
> 1. Change the current IOException to something else to fall within existing
> exception flow
> 2. Update current exception handling to send ExceptionResponse w/ the max
> message size message to the client before closing
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
