[
https://issues.apache.org/jira/browse/ARTEMIS-3662?focusedWorklogId=721035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721035
]
ASF GitHub Bot logged work on ARTEMIS-3662:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/22 17:32
Start Date: 04/Feb/22 17:32
Worklog Time Spent: 10m
Work Description: gemmellr edited a comment on pull request #3933:
URL:
https://github.com/apache/activemq-artemis/pull/3933#issuecomment-1030101326
From thinking on this a bit more though I wonder whether the actual xsd and
code default handling should also be getting updated for the 'jms' entries at
this point, so that if they werent explicitly configured in the xml config they
either default to whatever value the related 'regular' setting is using, or
just to false (at least for the auto-delete, since thats the provided default
config in xml now for the 'regular' setting...though it still defaults true in
the xsd and the code).
Since the -jms settings have been or are here removed from (or never existed
in) the default provided xml config, they then arent influenced by the use of
these variables set by the cli command flags anymore, but did used to be for
the auto-create ones at least. That means that the 'regular' and 'jms' settings
effective values will likely differ, e.g the auto-delete bit has xml false
config for the regular setting since 2.18.0, yet the -jms ones will still be
true from the xsd or code default....then for the auto-create, it has default
true set in the xml config for the 'regular' setting but can be configured
false with the CLI flags, yet doing so wont affect the -jms one anymore after
this change but would before, meaning they would remain true in the xsd and
code defaults despite a cli request to disable auto creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 721035)
Time Spent: 40m (was: 0.5h)
> Remove deprecated config from default broker.xml
> ------------------------------------------------
>
> Key: ARTEMIS-3662
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3662
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
