[ 
https://issues.apache.org/jira/browse/AMQ-8397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488134#comment-17488134
 ] 

Christopher L. Shannon commented on AMQ-8397:
---------------------------------------------

[~mattrpav] - For testing this you can probably just manually call the 
duplicateFromStore method on the destination and then verify if the message 
made it to the DLQ or not: 
https://github.com/apache/activemq/blob/main/activemq-broker/src/main/java/org/apache/activemq/broker/region/Destination.java#L247

It would be good to verify the policy gets applied on update as well (runtime 
configuration or dynamic changing at runtime manually.  
https://github.com/apache/activemq/blob/main/activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/PolicyEntry.java#L299

There's some runtime config tests you could add to for checking the update if 
you wanted: 
https://github.com/apache/activemq/blob/main/activemq-runtime-config/src/test/java/org/apache/activemq/PolicyEntryTest.java

 

> Add SendDuplicateFromStoreToDLQ flag to Destination
> ---------------------------------------------------
>
>                 Key: AMQ-8397
>                 URL: https://issues.apache.org/jira/browse/AMQ-8397
>             Project: ActiveMQ
>          Issue Type: New Feature
>    Affects Versions: 5.15.15
>            Reporter: Matt Pavlovich
>            Assignee: Matt Pavlovich
>            Priority: Major
>             Fix For: 5.17.0, 5.16.4
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When messages are loaded from the store under contention with concurrent 
> consumers, the broker detects duplicates and moves message to the DLQ for 
> that queue.
> This enhancement would add a configuration setting to DestinationPolicy to 
> optionally log, add a counter metric, and not move these message to the DLQ.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to