[
https://issues.apache.org/jira/browse/AMQ-5137?focusedWorklogId=728892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-728892
]
ASF GitHub Bot logged work on AMQ-5137:
---------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/22 11:57
Start Date: 17/Feb/22 11:57
Worklog Time Spent: 10m
Work Description: cshannon commented on pull request #771:
URL: https://github.com/apache/activemq/pull/771#issuecomment-1042873670
This change itself seems fine but I'm not sure if any existing network
bridge tests will break. So you need to check all the network tests and run
them to see if anything doesn't work now that the default changed.
Also, yes the change is trivial but again, all changes should have tests.
You don't need to write anything crazy but you could at least write a test to
verify the new default is true (could just check the network connector/bridge
or even use the JMX NetworkConnectorView after start up) to prevent getting
broken in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 728892)
Remaining Estimate: 0h
Time Spent: 10m
> make networkConnector decreaseNetworkConsumerPriority="true" the default
> ------------------------------------------------------------------------
>
> Key: AMQ-5137
> URL: https://issues.apache.org/jira/browse/AMQ-5137
> Project: ActiveMQ
> Issue Type: Improvement
> Affects Versions: 5.15.13
> Reporter: Gary Tully
> Assignee: Matt Pavlovich
> Priority: Major
> Labels: mesh, networkConnectors
> Fix For: 5.17.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It makes sense to bias local consumers, to avoid hops where possible.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
