[
https://issues.apache.org/jira/browse/ARTEMIS-2934?focusedWorklogId=729252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729252
]
ASF GitHub Bot logged work on ARTEMIS-2934:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/22 20:57
Start Date: 17/Feb/22 20:57
Worklog Time Spent: 10m
Work Description: asfgit closed pull request #3947:
URL: https://github.com/apache/activemq-artemis/pull/3947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729252)
Remaining Estimate: 0h
Time Spent: 10m
> ARTEMIS-2226 causes excessive notificaions to be sent for Spring XA clients
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2934
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2934
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Anton Roskvist
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hi,
> The fix in https://issues.apache.org/jira/browse/ARTEMIS-2226 causes
> excessive notifications to be sent for clients running XA transaction through
> the Spring framework.
> The notifications sent are SESSION_CREATED and SESSION_CLOSED.
> I strongly suspect this is because Spring DMLC cannot cache consumers
> properly when running XA, causing it to create and remove a new session for
> each message processed.
> Now I am not arguing that is not bad practice, because it is, but lots of
> applications run on top of this logic. I also suspect this might affect more
> but not be as pronounced.
>
> I have been able to prove the aforementioned patch is what causes the issue
> by removing:
> sendSessionNotification(CoreNotificationType.SESSION_CREATED);
> and
> sendSessionNotification(CoreNotificationType.SESSION_CLOSED);
> from ServerSessionImpl.java (they where added in the patch)
> Now I do not fully understand the intent of the original patch but I think it
> should be made conditional, that is, send those notifications only for MQTT
> session or something similar.
>
> In the environment I am testing this on the difference is huge as I have a
> lot of independent applications all running Spring+XA. About 40% of all
> messages getting sent and received are notifications.
>
> Br,
> Anton
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
