Robbie Gemmell created ARTEMIS-3695:
---------------------------------------
Summary: use specific jetty dependencies instead of jetty-all
Key: ARTEMIS-3695
URL: https://issues.apache.org/jira/browse/ARTEMIS-3695
Project: ActiveMQ Artemis
Issue Type: Task
Affects Versions: 2.20.0
Reporter: Robbie Gemmell
The build using the 'jetty-all' modules "uber" classified jar as a dependency
in numerous places. This dependency unfortunately also passes on all its
component dependencies of the individual jetty modules it includes, thus
meaning all the artemis modules using it also have the effective duplicate
dependencies (though for the resulting downloadable distribution archive, only
the uber jar is actually packaged in the end tar, due to some specific
filtering used, e.g [1][2]).
The Jetty folks say this artifact was not intended for users and shouldnt be
used, https://www.eclipse.org//lists/jetty-users/msg06029.html.
It has also already been removed in Jetty 10(/11) so this would also impede
upgrading to those newer releases [3].
The build should just depend on the invididual Jetty bits it needs in each
area.
[1]
https://github.com/apache/activemq-artemis/blob/ee52e3de7c5edb65ee0df463a17387672425b2ba/artemis-distribution/src/main/assembly/dep.xml#L39
[2]
https://github.com/apache/activemq-artemis/blob/ee52e3de7c5edb65ee0df463a17387672425b2ba/artemis-distribution/src/main/assembly/dep.xml#L50-L52
[3] [https://github.com/eclipse/jetty.project/issues/5317]
(A first step might just be to depend on all the individual bits that jetty-all
already does, and which the various modules using jetty-all are thus in turn
already getting. Then afterwards they could be rationalised to only depend on
the bits truly being used by each area).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
