[
https://issues.apache.org/jira/browse/AMQ-7426?focusedWorklogId=731582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731582
]
ASF GitHub Bot logged work on AMQ-7426:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/22 14:16
Start Date: 23/Feb/22 14:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #662:
URL: https://github.com/apache/activemq/pull/662#discussion_r812935277
##########
File path: activemq-all/pom.xml
##########
@@ -109,9 +105,8 @@
<include>org.apache.geronimo.specs:geronimo-j2ee-management_1.1_spec</include>
<include>org.apache.geronimo.specs:geronimo-annotation_1.0_spec</include>
<include>org.slf4j:slf4j-api</include>
- <include>org.slf4j:slf4j-log4j12</include>
+ <include>org.apache.logging:log4j-slf4j-impl</include>
Review comment:
Yes the comment wasnt about slf4j-log4j12 (that removal is obvious),
just the line below it as noted (which didnt change and so couldnt be commented
on, which is explicitly including org.slf4j:jcl-over-slf4j, as is the assemby,
yet the dependencyManagement for it was just removed in place of using the same
property in the assembly. I dont see why you would remove the version
management if still actually using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 731582)
Time Spent: 7h (was: 6h 50m)
> Upgrade to log4j2
> -----------------
>
> Key: AMQ-7426
> URL: https://issues.apache.org/jira/browse/AMQ-7426
> Project: ActiveMQ
> Issue Type: Task
> Components: Broker
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> This JIRA will upgrade 5.17.x to use Log4J 2.x instead of 1.x
> (5.16.x was switched to using [reload4j|https://reload4j.qos.ch/] instead of
> Log4j 1.x via AMQ-8472 in 5.16.4)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
