[
https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735354
]
ASF GitHub Bot logged work on AMQ-8520:
---------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/22 15:21
Start Date: 02/Mar/22 15:21
Worklog Time Spent: 10m
Work Description: jbonofre commented on a change in pull request #789:
URL: https://github.com/apache/activemq/pull/789#discussion_r817798807
##########
File path:
activemq-unit-tests/src/test/java/org/apache/activemq/ProducerFlowControlTest.java
##########
@@ -261,7 +261,7 @@ public void testDisableWarning() throws Exception {
Appender appender = new DefaultTestAppender() {
Review comment:
Instead of the DefaultTestAppender, you can now use log4j
AbstractAppender with var as I did in other modules.
##########
File path:
activemq-unit-tests/src/test/java/org/apache/activemq/broker/region/QueuePurgeTest.java
##########
@@ -108,31 +108,30 @@ private void testPurgeLargeQueue(boolean
prioritizedMessages) throws Exception {
QueueViewMBean proxy = getProxyToQueueViewMBean();
LOG.info("purging..");
- org.apache.log4j.Logger log4jLogger =
org.apache.log4j.Logger.getLogger(org.apache.activemq.broker.jmx.QueueView.class);
+ org.apache.logging.log4j.core.Logger log4jLogger =
(org.apache.logging.log4j.core.Logger)LogManager.getLogger(org.apache.activemq.broker.jmx.QueueView.class);
+
final AtomicBoolean gotPurgeLogMessage = new AtomicBoolean(false);
Appender appender = new DefaultTestAppender() {
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 735354)
Time Spent: 1h (was: 50m)
> Default maven build does not build all modules
> ----------------------------------------------
>
> Key: AMQ-8520
> URL: https://issues.apache.org/jira/browse/AMQ-8520
> Project: ActiveMQ
> Issue Type: Bug
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There are some optional modules defined under the profile "full.test". These
> modules need to be added by default back to the normal build so they are
> compiled and installed as there are dependencies on them for other modules.
> The tests can be skipped by default but the actual modules need to still
> always be built. This is a problem as now version 5.18 fails to build without
> old snapshots plus it means all of the testing in CI is using stale snapshots.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
