[
https://issues.apache.org/jira/browse/ARTEMIS-3719?focusedWorklogId=740958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-740958
]
ASF GitHub Bot logged work on ARTEMIS-3719:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/22 15:46
Start Date: 14/Mar/22 15:46
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3984:
URL: https://github.com/apache/activemq-artemis/pull/3984#discussion_r826103199
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1975,19 +1970,14 @@ public void expire(final MessageReference ref) throws
Exception {
@Override
public void expire(final MessageReference ref, final ServerConsumer
consumer) throws Exception {
- SimpleString messageExpiryAddress = expiryAddressFromMessageAddress(ref);
- if (messageExpiryAddress == null) {
- messageExpiryAddress = expiryAddressFromAddressSettings(ref);
- }
-
- if (messageExpiryAddress != null) {
+ if (addressSettings.getExpiryAddress() != null) {
Review comment:
We used to get the address from the message because of original queue
versus current queue.
I believe we would have tests validating that.. (if no testa re failing,
there's still a semantic change here I guess we need to be careful).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 740958)
Time Spent: 20m (was: 10m)
> Dead-letter and expiry address not applied when using temp-queue-namespace
> --------------------------------------------------------------------------
>
> Key: ARTEMIS-3719
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3719
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
