[ 
https://issues.apache.org/jira/browse/ARTEMIS-3720?focusedWorklogId=742523&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742523
 ]

ASF GitHub Bot logged work on ARTEMIS-3720:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/22 16:41
            Start Date: 16/Mar/22 16:41
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on a change in pull request #3983:
URL: https://github.com/apache/activemq-artemis/pull/3983#discussion_r828153835



##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -894,6 +894,15 @@
             </xsd:annotation>
          </xsd:element>
 
+         <xsd:element name="global-max-messages" type="xsd:long" default="-1" 
maxOccurs="1" minOccurs="0">
+            <xsd:annotation>
+               <xsd:documentation>
+                  Number of messages before all addresses will enter into 
their Full Policy configured.
+                  It works in conjunction with global-max-message-size, being 
watever value hits its maximum first.

Review comment:
       There are no other mentions of global-max-message-size in the 
codebase....global-max-size?

##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -3934,6 +3943,14 @@
                </xsd:annotation>
             </xsd:element>
 
+            <xsd:element name="max-size-messages" type="xsd:long" default="-1" 
maxOccurs="1" minOccurs="0">

Review comment:
       What about _max-size-message-count_? Would be consistent with the queues 
use of MessageCount as its depth metric, and less likely to be confused in 
discussion with bits around 'size of message' as opposed to 'number of 
messages'.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 742523)
    Time Spent: 3h  (was: 2h 50m)

> Max number of messages as a deciding factor for Paging
> ------------------------------------------------------
>
>                 Key: ARTEMIS-3720
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3720
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.21.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to