[
https://issues.apache.org/jira/browse/ARTEMIS-3707?focusedWorklogId=753617&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753617
]
ASF GitHub Bot logged work on ARTEMIS-3707:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/22 19:16
Start Date: 06/Apr/22 19:16
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #3999:
URL:
https://github.com/apache/activemq-artemis/pull/3999#issuecomment-1090666094
@waldi5001
```
merge commits are confusing..
I will avoid that.
should we split some commits in a new PR? Wouldn't that be cleaner?
```
I would just for now:
```
git remote add upstream https://github.com/apache/activemq-artemis.git
git pull --rebase upstream main
git push origin -f
```
Right before commit, I would squash all the commits into a single commit...
it's ok to keep separate commits while reviewing.. but this to me is a single
unit of work...
if you want to separate commits to make it more manageable is fine.. but on
this PR you have for instance a commit just to fix check style.. that should be
squashed.
last time I checked all these commits could / should be squashed into a
single commit and push -f
Issue Time Tracking
-------------------
Worklog Id: (was: 753617)
Time Spent: 3h 20m (was: 3h 10m)
> ResourceAdapter improvements
> ----------------------------
>
> Key: ARTEMIS-3707
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3707
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Waldi
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Hi Everybody,
> I've tried to install the resourceAdapter in openliberty/WLP by myself. I've
> got in some troubles and fixed it by myself. Now, I would like to provide the
> modifications and a small piece of documentation of the resourceAdapter, if
> interested.
> * Sample config / project for openliberty/WLP
> * remove usage of the transactionManager in the resource adapter
> * fix the jakarta ra.xml namespaces and classnames
> * create a maven build for a rar archive with fewer dependencies and
> therefore a smaller footprint.
> I took notice of ARTEMIS-1487 and ARTEMIS-1614. In my opinion, with my
> contributions, we can close these issues. Can you tell me your thoughts and
> give me feedback?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
