[
https://issues.apache.org/jira/browse/ARTEMIS-3778?focusedWorklogId=756953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-756953
]
ASF GitHub Bot logged work on ARTEMIS-3778:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 12:56
Start Date: 14/Apr/22 12:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4029:
URL: https://github.com/apache/activemq-artemis/pull/4029#discussion_r850415283
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java:
##########
@@ -1846,43 +1844,47 @@ private final class ExpiryReaper extends
ActiveMQScheduledComponent {
super(scheduledExecutorService, executor, checkPeriod, timeUnit,
onDemand);
}
- volatile CountDownLatch inUseLatch;
+ volatile Iterator<Queue> iterator;
@Override
public void stop() {
super.stop();
// this will do a best effort to stop the current latch.
// no big deal if it failed. this is just to optimize this component
stop.
- CountDownLatch latch = inUseLatch;
- if (latch != null) {
- latch.countDown();
- }
Review Comment:
removed the left over method
Issue Time Tracking
-------------------
Worklog Id: (was: 756953)
Time Spent: 50m (was: 40m)
> Reaper reporting TimeoutException on Reaper threads
> ---------------------------------------------------
>
> Key: ARTEMIS-3778
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3778
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.21.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.22.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If a queue is holding too many references, and it takes more than 10 seconds
> to iterate on references, the reaper will log an error:
> AMQ224013: failed to expire messages for queue:
> java.util.concurrent.TimeoutException
> Instead I should streamline reaping to resume the next queue when one queue
> is done. This way no thread is held blocking and we just streamline the
> process.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
