[
https://issues.apache.org/jira/browse/AMQ-8513?focusedWorklogId=757903&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757903
]
ASF GitHub Bot logged work on AMQ-8513:
---------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/22 14:33
Start Date: 18/Apr/22 14:33
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #782:
URL: https://github.com/apache/activemq/pull/782#discussion_r852150854
##########
activemq-spring/pom.xml:
##########
@@ -87,6 +87,11 @@
<artifactId>org.linkedin.zookeeper-impl</artifactId>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.ant</groupId>
+ <artifactId>ant</artifactId>
+ <scope>provided</scope>
+ </dependency>
Review Comment:
Is this actually needed? It was only a transitive dependency before, sio
unless the module has its own Ant usage it seems like it should still be
transitive.
The dependencyManagement will still control the version without adding this,
and the scope be based on the scope of whatever pulls it in transitively.
##########
pom.xml:
##########
@@ -639,6 +646,10 @@
<artifactId>org.linkedin.zookeeper-impl</artifactId>
<version>${linkedin-zookeeper-version}</version>
<exclusions>
+ <exclusion>
+ <groupId>ant</groupId>
+ <artifactId>ant</artifactId>
+ </exclusion>
Review Comment:
As prior comment, this exclusion doesnt seem like it would be doing
anything, as org.linkedin.zookeeper-impl wasnt showing a dependency on
"ant:ant" previously, only "org.apache.ant:ant". Seems like it can be removed.
##########
activemq-partition/pom.xml:
##########
@@ -49,6 +49,10 @@
<groupId>org.linkedin</groupId>
<artifactId>org.linkedin.zookeeper-impl</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.ant</groupId>
+ <artifactId>ant</artifactId>
+ </dependency>
Review Comment:
As other comment, is this actually needed?
Issue Time Tracking
-------------------
Worklog Id: (was: 757903)
Time Spent: 2.5h (was: 2h 20m)
> Upgrade to ant 1.10.12
> ----------------------
>
> Key: AMQ-8513
> URL: https://issues.apache.org/jira/browse/AMQ-8513
> Project: ActiveMQ
> Issue Type: Dependency upgrade
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.1, 5.16.5
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
