[
https://issues.apache.org/jira/browse/AMQ-8601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ding Ding updated AMQ-8601:
---------------------------
Description:
Hello,
While viewing the MAPREDUCE-4262, I found that the logging statements might
give inaccurate messages.
I also found that the in the line *93* of the file
[UpdateVirtualDestinationsTask|https://github.com/apache/activemq/blob/b3c2c49f96bebee14b74c6456feb233e0312724b/activemq-runtime-config/src/main/java/org/apache/activemq/plugin/UpdateVirtualDestinationsTask.java#L93],
the log messages says "{_}Removing virtual destination "{_}. However, the
removing action should already completed in previous code ({*}line 92{*}).
{code:java}
plugin.virtualDestinationRemoved(connectionContext, removedVirtualDest);
LOG.info("Removing virtual destination: {}",
removedVirtualDest); {code}
Would it be better if we change the verb "Removing" to "Removed" to indicate
the action is completed, which is similar to the previous logging statement?
{code:java}
virtualDestinationInterceptor
.setVirtualDestinations(getVirtualDestinations());
plugin.info("applied updates to: "
+ virtualDestinationInterceptor); {code}
Or can we move the logging statement to the line before {*}92{*}? Since when
there was an exception in previous lines, the logging message would not be
printed, which may be not good for debugging.
was:
Hello,
While viewing the MAPREDUCE-4262, I found that the logging statements might
give inaccurate messages.
I also found that the in the line *93* of the file
[UpdateVirtualDestinationsTask|https://github.com/apache/activemq/blob/b3c2c49f96bebee14b74c6456feb233e0312724b/activemq-runtime-config/src/main/java/org/apache/activemq/plugin/UpdateVirtualDestinationsTask.java#L93],
the log messages says "{_}Removing virtual destination "{_}. However, the
removing action should already completed in previous code ({*}line 92{*}).
{code:java}
plugin.virtualDestinationRemoved(connectionContext, removedVirtualDest);
LOG.info("Removing virtual destination: {}",
removedVirtualDest); {code}
Would it be better if we change the verb "Removing" to "Removed" to indicate
the action is completed, which is similar to the previous logging statement?
{code:java}
virtualDestinationInterceptor
.setVirtualDestinations(getVirtualDestinations());
plugin.info("applied updates to: " +
virtualDestinationInterceptor); {code}
Or can we move the logging statement to the line before {*}92{*}? Since when
there was an exception in previous lines, the logging message would not be
printed, which may be not good for debugging.
> UpdateVirtualDestinationsTask gives inaccurate log message saying "Removing
> virtual destination ... " after already applied the removal
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-8601
> URL: https://issues.apache.org/jira/browse/AMQ-8601
> Project: ActiveMQ
> Issue Type: Bug
> Reporter: Ding Ding
> Priority: Trivial
>
> Hello,
> While viewing the MAPREDUCE-4262, I found that the logging statements might
> give inaccurate messages.
> I also found that the in the line *93* of the file
> [UpdateVirtualDestinationsTask|https://github.com/apache/activemq/blob/b3c2c49f96bebee14b74c6456feb233e0312724b/activemq-runtime-config/src/main/java/org/apache/activemq/plugin/UpdateVirtualDestinationsTask.java#L93],
> the log messages says "{_}Removing virtual destination "{_}. However, the
> removing action should already completed in previous code ({*}line 92{*}).
> {code:java}
> plugin.virtualDestinationRemoved(connectionContext, removedVirtualDest);
> LOG.info("Removing virtual destination: {}",
> removedVirtualDest); {code}
> Would it be better if we change the verb "Removing" to "Removed" to indicate
> the action is completed, which is similar to the previous logging statement?
> {code:java}
> virtualDestinationInterceptor
> .setVirtualDestinations(getVirtualDestinations());
> plugin.info("applied updates to: "
> + virtualDestinationInterceptor); {code}
> Or can we move the logging statement to the line before {*}92{*}? Since when
> there was an exception in previous lines, the logging message would not be
> printed, which may be not good for debugging.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
