[
https://issues.apache.org/jira/browse/ARTEMIS-3826?focusedWorklogId=770252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770252
]
ASF GitHub Bot logged work on ARTEMIS-3826:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/22 16:00
Start Date: 13/May/22 16:00
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4075:
URL: https://github.com/apache/activemq-artemis/pull/4075#discussion_r872558990
##########
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java:
##########
@@ -722,6 +722,23 @@ public void
testSetNestedPropertyOnExistingCollectionEntryViaMappedNotation() th
Assert.assertEquals("TF",
configuration.getConnectionRouters().get(0).getKeyFilter());
}
+
+ @Test
+ public void testAddressViaProperties() throws Throwable {
+ ConfigurationImpl configuration = new ConfigurationImpl();
+
+ Properties properties = new Properties();
+
+
properties.put("addressConfigurations.\"LB.TEST\".queueConfigs.\"LB.TEST\".routingType",
"ANYCAST");
Review Comment:
excellent review, thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 770252)
Time Spent: 1h (was: 50m)
> properties config - allow address and queue configuration
> ----------------------------------------------------------
>
> Key: ARTEMIS-3826
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3826
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.22.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.23.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> the accessor Configs need to be visible and a no args constructor is absent
> in addition, we need type conversion on the name attribute to match
> SimpleString
>
> this will allow queue creation via a property of the form:
> addressConfigurations.\"LB.TEST\".queueConfigs.\"LB.TEST\".routingType=ANYCAST
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
