[
https://issues.apache.org/jira/browse/ARTEMIS-3139?focusedWorklogId=786607&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786607
]
ASF GitHub Bot logged work on ARTEMIS-3139:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 14:08
Start Date: 30/Jun/22 14:08
Worklog Time Spent: 10m
Work Description: ryan-highley commented on code in PR #4122:
URL: https://github.com/apache/activemq-artemis/pull/4122#discussion_r911073599
##########
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##########
@@ -16,18 +16,23 @@
limitations under the License.
Review Comment:
The intent of the changes is to remove all the embedded {{element}} and
{{complexType}} definitions from the {{core}} definition.
By moving these schema definitions, XML tooling becomes valid for both
included XML elements and the overall {{broker.xml}} file. As with the
{{diverts}} example in the JIRA (not mine--just trying to address it), an IDE
has no idea what a {{diverts}} is outside of a {{core}} element, meaning syntax
help is not available. Any other valid imported element file, e.g. included
files containing top-level {{addresses}}, {{connectors}}, {{acceptors}}, etc.
elements, would also have the same syntax tooling support.
As you mentioned, XML includes work just fine currently, but the schema
definition as it currently stands does not support included element files as
well as it can and should.
Issue Time Tracking
-------------------
Worklog Id: (was: 786607)
Time Spent: 1h 40m (was: 1.5h)
> Anonymous types in artemis-configuration.xsd
> --------------------------------------------
>
> Key: ARTEMIS-3139
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3139
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Tuve Nordius
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The artemis-configuration.xsd has a lot of anonymous types which makes it
> hard to create a modulirized configuration. If I want to have diverts in a
> seperate file I can do that but I cant get any validation/ help for any
> editor.
> example:
> I can do in an included file diverts.xml something like
> {code:java}
> <diverts xmlns="urn:activemq:core">{code}
> I would like to do like bellow, but I can't since divertsType does not exist
> other as an inline anonymous type.
>
> {code:java}
> <diverts xmlns="urn:activemq:core"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="urn:activemq:core
> /schema/artemis-configuration.xsd"
> xsi:type="divertsType" >
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
