[
https://issues.apache.org/jira/browse/ARTEMIS-3901?focusedWorklogId=794151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794151
]
ASF GitHub Bot logged work on ARTEMIS-3901:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/22 09:50
Start Date: 22/Jul/22 09:50
Worklog Time Spent: 10m
Work Description: jsmucr commented on code in PR #4154:
URL: https://github.com/apache/activemq-artemis/pull/4154#discussion_r927489756
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/PerfClientCommand.java:
##########
@@ -131,6 +134,7 @@ protected void onExecuteBenchmark(final ConnectionFactory
producerConnectionFact
.setTimeProvider(() ->
TimeUnit.NANOSECONDS.toMicros(System.nanoTime()))
.setCanDelayMessageCount(true)
.setSharedSubscription(sharedSubscription)
+ .setClientID(UUID.randomUUID().toString())
Review Comment:
There it is:
```
java.lang.RuntimeException: javax.jms.IllegalStateException: Cannot create
durable subscription - client ID has not been set
at
org.apache.activemq.artemis.cli.commands.messages.perf.MessageListenerBenchmark.start(MessageListenerBenchmark.java:221)
at
org.apache.activemq.artemis.cli.commands.messages.perf.PerfClientCommand.onExecuteBenchmark(PerfClientCommand.java:171)
at
org.apache.activemq.artemis.cli.commands.messages.perf.PerfCommand.execute(PerfCommand.java:79)
at
org.apache.activemq.artemis.cli.commands.messages.perf.PerfClientCommand.execute(PerfClientCommand.java:214)
at
org.apache.activemq.cli.test.CliPerfClientTest$1.execute(CliPerfClientTest.java:55)
at
org.apache.activemq.cli.test.CliPerfClientTest.start(CliPerfClientTest.java:58)
at
org.apache.activemq.cli.test.CliPerfClientTest.testDurableStarts(CliPerfClientTest.java:68)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
at
com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
at
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: javax.jms.IllegalStateException: Cannot create durable
subscription - client ID has not been set
at
org.apache.activemq.artemis.jms.client.ActiveMQSession.createConsumer(ActiveMQSession.java:865)
at
org.apache.activemq.artemis.jms.client.ActiveMQSession.createDurableConsumer(ActiveMQSession.java:661)
at
org.apache.activemq.artemis.jms.client.ActiveMQSession.createDurableConsumer(ActiveMQSession.java:643)
at
org.apache.activemq.artemis.cli.commands.messages.perf.MessageListenerBenchmark.start(MessageListenerBenchmark.java:214)
... 37 more
```
Issue Time Tracking
-------------------
Worklog Id: (was: 794151)
Time Spent: 40m (was: 0.5h)
> artemis perf client --durable fails on exception
> ------------------------------------------------
>
> Key: ARTEMIS-3901
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3901
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.24.0
> Reporter: Jan Šmucr
> Priority: Major
> Attachments: CliPerfClientTest.java
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The cli command
> {noformat}
> bin/artemis perf client --durable{noformat}
> fails with an exception:
> {noformat}
> java.lang.ClassCastException: class
> org.apache.activemq.artemis.jms.client.ActiveMQQueue cannot be cast to class
> javax.jms.Topic (org.apache.activemq.artemis.jms.client.ActiveMQQueue and
> javax.jms.Topic are in unnamed module of loader 'app')
> at
> org.apache.activemq.artemis.cli.commands.messages.perf.MessageListenerBenchmark.start(MessageListenerBenchmark.java:213)
> at
> org.apache.activemq.artemis.cli.commands.messages.perf.PerfClientCommand.onExecuteBenchmark(PerfClientCommand.java:167)
> at
> org.apache.activemq.cli.test.CliPerfClientTest$1.onExecuteBenchmark(CliPerfClientTest.java:66)
> at
> org.apache.activemq.artemis.cli.commands.messages.perf.PerfCommand.execute(PerfCommand.java:79)
> at
> org.apache.activemq.cli.test.CliPerfClientTest.start(CliPerfClientTest.java:69)
> at
> org.apache.activemq.cli.test.CliPerfClientTest.testDurableStarts(CliPerfClientTest.java:79){noformat}
> Non-durable method works fine.
> See the attached test file or
> https://github.com/jsmucr/activemq-artemis/tree/perf-client-durable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
