Clebert Suconic created ARTEMIS-3909:
----------------------------------------
Summary: Move RoutingContext::processReferences to PostOfficeImpl
Key: ARTEMIS-3909
URL: https://issues.apache.org/jira/browse/ARTEMIS-3909
Project: ActiveMQ Artemis
Issue Type: Task
Reporter: Clebert Suconic
Assignee: Clebert Suconic
Reasoning:
- We reuse the Routing Context as an optimization on the ServerSession.
- By the time the Routing is done, we will process the references on a IO
callback.
- if anyone used any state in between the Routing and Storage, you could have
an invalid operation.
We were lucky that the method processReferences in PostOffice was pretty much
static and no actual bug happened because of that, however I almost thought we
had something scary going on.
So, to avoid this kind of issue ever being introduced in the codebase I am
moving the processReferences away from RoutingContext.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
