[
https://issues.apache.org/jira/browse/AMQ-9005?focusedWorklogId=796959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796959
]
ASF GitHub Bot logged work on AMQ-9005:
---------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 17:01
Start Date: 01/Aug/22 17:01
Worklog Time Spent: 10m
Work Description: lucastetreault commented on PR #870:
URL: https://github.com/apache/activemq/pull/870#issuecomment-1201470213
> Other xalan references need to be cleaned up and XPath unit tests validated
>
>
./activemq-client/src/main/java/org/apache/activemq/filter/XPathExpression.java
./activemq-broker/src/main/java/org/apache/activemq/filter/XalanXPathEvaluator.java
So I'm not entirely sure what to do with these...
activemq-broker/src/main/java/org/apache/activemq/filter/XalanXPathEvaluator
is actually identical to
activemq-broker/src/main/java/org/apache/activemq/filter/JAXPXPathEvaluator and
neither of them use Xalan. I guess we can delete XalanXPathEvaluator and change
the reference to it in XPathExpression to use JAXPXPathEvaluator.
The SelectorParserTest is the only test I can find using XPathExpression and
it passes with these changes.
> > xalan reference missed:
> >
https://github.com/apache/activemq/blob/main/assembly/src/release/examples/conf/resin-web.xml
>
> I'm guessing but that TransformerFactory setting can probably just be
removed. That would likely mean that the JDK built-in transformer is used
(unless another JAXP compliant transformer was on the classpath, eg Saxon).
I don't know anything about resin. How can I test this?
Issue Time Tracking
-------------------
Worklog Id: (was: 796959)
Time Spent: 1h 10m (was: 1h)
> remove xalan dependency due to it being end of life
> ---------------------------------------------------
>
> Key: AMQ-9005
> URL: https://issues.apache.org/jira/browse/AMQ-9005
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: PJ Fanning
> Priority: Major
> Fix For: 5.18.0, 5.17.2
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Xalan is no longer supported.
> https://lists.apache.org/thread/s8kjny5270ssfcp46v0fl39lk98987w7
> It is better to use JAXP TransformerFactory than using xalan directly. If you
> add xalan dependency just to ensure that you have a JAXP compliant
> transformer on the classpath, this is unnecessary - the Java runtime has a
> built-in implementation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
