[
https://issues.apache.org/jira/browse/ARTEMIS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575533#comment-17575533
]
Justin Bertram edited comment on ARTEMIS-3913 at 8/5/22 2:58 AM:
-----------------------------------------------------------------
I'd need a way to reproduce what you're seeing. At the very least I need a
[protocol trace
log|https://activemq.apache.org/components/artemis/documentation/latest/mqtt.html#debug-logging]
which captures the problem.
There are tests in the test-suite which verify an MQTT 5 client gets a
{{CONNACK}} packet with a reason code of {{134}} ({{0x86}}) when authentication
fails, and those tests are succeeding. See:
*
[{{o.a.a.a.t.i.m.s.c.ConnectTestsWithSecurity#testAuthenticationFailureWithBadCredentials}}|https://github.com/apache/activemq-artemis/blob/main/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTestsWithSecurity.java#L51]
*
[{{o.a.a.a.t.i.m.s.c.ConnectTestsWithSecurity#testAuthenticationFailureWithNoCredentials}}|https://github.com/apache/activemq-artemis/blob/382267bf6364dec890f27ca1927394499c83a85b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTestsWithSecurity.java#L64]
For what it's worth, those tests are using the Paho 1.2.5 client as well.
was (Author: jbertram):
I'd need a way to reproduce what you're seeing. At the very least I need a
[protocol trace
log|https://activemq.apache.org/components/artemis/documentation/latest/mqtt.html#debug-logging]
which captures the problem.
There are tests in the test-suite which verify an MQTT 5 client gets a
{{CONNACK}} packet with a reason code of {{134}} ({{0x86}}) when authentication
fails, and those tests are succeeding. See:
*
[{{org.apache.activemq.artemis.tests.integration.mqtt5.spec.controlpackets.ConnectTestsWithSecurity#testAuthenticationFailureWithBadCredentials}}|https://github.com/apache/activemq-artemis/blob/main/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTestsWithSecurity.java#L51]
*
[{{org.apache.activemq.artemis.tests.integration.mqtt5.spec.controlpackets.ConnectTestsWithSecurity#testAuthenticationFailureWithNoCredentials}}|https://github.com/apache/activemq-artemis/blob/382267bf6364dec890f27ca1927394499c83a85b/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/mqtt5/spec/controlpackets/ConnectTestsWithSecurity.java#L64]
For what it's worth, those tests are using the Paho 1.2.5 client as well.
> MQTTReasonCodes byte loss of precision，must int type
> ----------------------------------------------------
>
> Key: ARTEMIS-3913
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3913
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: gongping.zhu
> Priority: Major
> Attachments: image-2022-08-02-08-23-52-965.png,
> image-2022-08-02-08-24-39-288.png, image-2022-08-02-08-31-01-074.png,
> image-2022-08-02-08-42-24-117.png, image-2022-08-02-08-43-39-442.png,
> image-2022-08-02-08-45-11-459.png, image-2022-08-02-08-54-34-267.png,
> image-2022-08-05-08-32-12-492.png
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
