[
https://issues.apache.org/jira/browse/ARTEMIS-2618?focusedWorklogId=805007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805007
]
ASF GitHub Bot logged work on ARTEMIS-2618:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/22 20:57
Start Date: 30/Aug/22 20:57
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #3795:
URL:
https://github.com/apache/activemq-artemis/pull/3795#issuecomment-1232159935
the reason I never merged this, was because I was more afraid of side
effects than anything else.
What if the Open did leave a file handle open somewhere in the OS, and still
issued a warning? How to test it (as a matter of fact there are no tests on
this PR, and even if we had it.. it would be difficult to validate it).
and the reason I never closed it... it was I wanted to be polite and find a
middle term solution.. but I could never accommodate the request in a way I
felt comfortable on merging.
@MrEasy I will close this now, and close the JIRA as a won't fix... just
because of those reasons.
Sorry it took me 2 years to close it.. but at the time you open I tried to
find a solution and I never came to it.
And as anything... 2021 was a weird year to me... it seems 2 years passed
like yesterday.
Issue Time Tracking
-------------------
Worklog Id: (was: 805007)
Time Spent: 50m (was: 40m)
> Improve Handling of Shutdown on critical I/O Error
> --------------------------------------------------
>
> Key: ARTEMIS-2618
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2618
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.11.0
> Reporter: Rico Neubauer
> Priority: Major
> Fix For: 2.25.0
>
> Attachments: Improve-Handling-of-Shutdown-on-critic.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Would like to request an improvement in the handling of critical I/O errors
> on opening journal files.
> If {{org.apache.activemq.artemis.core.io.nio.NIOSequentialFile}} fails to
> open a journal file, the whole server shuts down with {{@Message(id = 222010,
> value = "Critical IO Error, shutting down the server. file=1, message=0"}}.
> We have seen this in the wild, where a backup-software locked the file for a
> short time while journal was about getting opened, resulting in the shutdown.
> Proposed improvement would be to have a short-running retry for opening the
> journal files and only fail fatally if error persists.
> Will attach a proposal patch. Can also create a PR if you accept.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
