[
https://issues.apache.org/jira/browse/ARTEMIS-3763?focusedWorklogId=805257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805257
]
ASF GitHub Bot logged work on ARTEMIS-3763:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 14:22
Start Date: 31/Aug/22 14:22
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4200:
URL:
https://github.com/apache/activemq-artemis/pull/4200#issuecomment-1233006843
We would need at least a Mocking test validating it. a test with a real
Database (we use Derby in a lot of tests) would be my preferred option.
Issue Time Tracking
-------------------
Worklog Id: (was: 805257)
Time Spent: 2h 50m (was: 2h 40m)
> Use configurable time margin for checking offset between database server and
> broker
> -----------------------------------------------------------------------------------
>
> Key: ARTEMIS-3763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3763
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: 2.21.0
> Reporter: Marlon Müller
> Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> When using JDBC persistence artemis checks for time differences between the
> broker and the database. Currently this check requests the time of the
> database and compares it to the system time before and after sending this
> query by removing the milliseconds and verifying that the database time is
> between the start and the end time.
> This leads to somehow random warnings in the log depending on the current
> milliseconds when this check is performed.
> For example if the time on your artemis server is 00:00:01.000 before the
> check and the time on the database is 00:00:00.999 it will log a warning
> although there is only 1 millisecond difference. On the other hand if your
> artemis server time is 00:00:01.000 after sending the query and the database
> time is 00:00:01.999 there will be no warning although the time is 999
> milliseconds after the end time.
> Therefore it would be better to use a consistent margin for the database time
> during this check. To avoid problems in setups where the system times are not
> well synchronized, this time margin should be configurable to allow the user
> to fine tune it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
