[
https://issues.apache.org/jira/browse/AMQ-6148?focusedWorklogId=807542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807542
]
ASF GitHub Bot logged work on AMQ-6148:
---------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/22 18:29
Start Date: 09/Sep/22 18:29
Worklog Time Spent: 10m
Work Description: Dm-Chebotarskyi commented on code in PR #699:
URL: https://github.com/apache/activemq/pull/699#discussion_r967360453
##########
activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java:
##########
@@ -175,7 +171,7 @@ public boolean commit() throws LoginException {
public boolean abort() throws LoginException {
if (!succeeded) {
return false;
- } else if (succeeded && commitSucceeded) {
Review Comment:
succeeded is alway `true` in line 174. Logic hasn't been changed
Issue Time Tracking
-------------------
Worklog Id: (was: 807542)
Time Spent: 1h 40m (was: 1.5h)
> When use LDAP auth, Activemq should not always connect to ldap service to do
> authentication
> -------------------------------------------------------------------------------------------
>
> Key: AMQ-6148
> URL: https://issues.apache.org/jira/browse/AMQ-6148
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 5.11.1
> Reporter: JIE CHEN
> Priority: Critical
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> I am using LDAP service to do authentication for ActiveMQ, and I found
> everytime ActiveMQ servers try to establish a connection between ActiveMQ
> client, the ActiveMQ server will create a connection to LDAP server to do
> authentication. That's is not good, think about there are thousands of
> ActiveMQ clients are trying to connect to ActiveMQ servers, the ActiveMQ
> servers will need to create thousands of connections to LDAP servers. And
> moreover it is not reliable as well because the connection between LDAP
> servers and ActiveMQ servers could be broken sometimes. We need something
> similar as Cached LDAP Authorization Module. It is more reasonable that the
> ActiveMQ will cache the ldap account credential in local memory and refresh
> in certain interval.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
