[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=813030&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813030
]
ASF GitHub Bot logged work on ARTEMIS-4020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/22 16:04
Start Date: 28/Sep/22 16:04
Worklog Time Spent: 10m
Work Description: tabish121 commented on PR #4235:
URL:
https://github.com/apache/activemq-artemis/pull/4235#issuecomment-1261130569
> > Possible future enhancement would be to replace hard coding class names
in logger definitions with Methodhandle lookups
> > `Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());`
> > This tends to help when cutting and pasting loggers and forgetting to
change the class name.
>
> Yeah I didnt know about that trick, probably would be good to consider as
I knew there were a few incorrect ones (forget it they are fixed in here, or
were previously on main). But yes, I'd say better to do that separately later.
Indeed the changes would be large given how many bad logging usages I see.
Most of the gating that is currently done is either not needed or wouldn't be
needed if loggers used the formatting style as they should.
Issue Time Tracking
-------------------
Worklog Id: (was: 813030)
Time Spent: 1h 20m (was: 1h 10m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Robbie Gemmell
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> <broker-instance>/etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
