[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815211
]
ASF GitHub Bot logged work on ARTEMIS-4020:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/22 13:33
Start Date: 10/Oct/22 13:33
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991291616
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
Review Comment:
Yes, and I'm saying I really dont think we should try to fix it ourselves,
as I did time you tried, because we cant really fix it properly ourselves, and
we cant be sure of the effect doing it will have. Even with what you did it
still has no effect until the next startup even if they dont have alternative
valid config and it isnt interfering with other config.
The JBoss Logging stuff comes in via the scripts hardcoding it, scripts that
also wont have been updated if you dont follow the update instructions. Thats
then picked up when the Java Util Logging stuff in the Artemis class kicks in
and makes it go look for the JBoss LogManager as instructed by the script.
Issue Time Tracking
-------------------
Worklog Id: (was: 815211)
Time Spent: 8h 40m (was: 8.5h)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -----------------------------------------------------------------------------
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> <broker-instance>/etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
